Draft
Conversation
This change updates the publish workflow to support tagging with the
`${packageName}/v${version}` format so that we can publish packages
independent of each other now that we are not bumping the version of all
packages at the same time. This also adds a script to parse the output
of `cargo metadata` to get the correct package name and version for all
packages in the workspace. This is used to validate the tag before
publishing to ensure that we are only publishing the package that we
intend to publish.
Also updated is the `attach-static-libs` workflow to only trigger on the
`firewood-ffi` release tag since that is the only package that triggers
an update to the Go wrapper module.
Closes: #1560
Closes: #1561
demosdemon
force-pushed
the
brandon.leblanc/cargo-publish-token
branch
from
6ddea2f to
7f4fa7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the publish workflow to support tagging with the
${packageName}/v${version}format so that we can publish packages independent of each other now that we are not bumping the version of all packages at the same time. This also adds a script to parse the output ofcargo metadatato get the correct package name and version for all packages in the workspace. This is used to validate the tag before publishing to ensure that we are only publishing the package that we intend to publish.Also updated is the
attach-static-libsworkflow to only trigger on thefirewood-ffirelease tag since that is the only package that triggers an update to the Go wrapper module.Closes: #1560
Closes: #1561